## Description `OpenRGB.exe --save-profile <existing>` removes the complete top-level `plugins` object from an existing JSON profile. OpenRGB reports that the profile was saved successfully. The normal GUI workflow is not affected. **Save Profile** opens the profile editor, which calls `SaveProfileCustom()` and serializes the plugins selected in **Include In Profile**. This report concerns the separate non-editor `ProfileManager::SaveProfile()` path used by `--save-profile`. ## Reproduction I reproduced this with the untouched development build at `7fed68ccf1a2413b9bd38a70e266b12cb2d59c26`. 1. Create an isolated configuration directory with a `profiles` subdirectory. 2. Put a valid version-6 profile at `profiles/PluginSaveProbe.json`. 3. Give it 11 normal controller entries and this plugin data: ```json "plugins": { "Plugin A": { "state": "cpu_temp" }, "Plugin B": { "value": 42 } } ``` 4. Run: ```powershell OpenRGB.exe ` --nodetect ` --noautoconnect ` --config C:\Temp\OpenRGB-profile-save-repro ` --save-profile PluginSaveProbe ` --loglevel 6 ``` 5. Read `profiles/PluginSaveProbe.json` again. OpenRGB exits with code 0 and logs: ```text [Info][CLI] Profile saved successfully ``` The resulting profile still contains all 11 controllers, but the `plugins` key is absent. ## Expected behavior A non-editor overwrite should preserve existing plugin data when no loaded `PluginManager` is available to refresh it. Profiles without plugin data should not gain a `plugins` key. This matches the stated purpose of commit [`7e74c295`](https://gitlab.com/CalcProgrammer1/OpenRGB/-/commit/7e74c295a350de1c55cccc51d817881b5764fb7e): > When updating existing profile without profile editor dialog, keep saved > states for unavailable controllers, base color, and only update plugins > already part of the existing profile ## Root cause `ProfileManager::SaveProfile()` reads `existing_profile_json`, then builds a new `profile_json` containing the profile name, version, base color, and controller states. Plugin data is added only inside: ```cpp if(plugin_manager != NULL) ``` The CLI path has no `PluginManager`, so no plugin data is copied into the rebuilt profile. There is also a separate lookup inside the live-manager branch: ```cpp if(profile_json["plugins"].contains(...)) ``` At that point, `profile_json` is the new document and has no plugin entries. The selection should come from `existing_profile_json`. ## Suggested fix One possible fix is to copy the existing plugin object before the optional live refresh. A loaded plugin manager can then refresh the plugins it knows about as before. ```diff diff --git a/ProfileManager.cpp b/ProfileManager.cpp index 7087240b..c4eef2be 100644 --- a/ProfileManager.cpp +++ b/ProfileManager.cpp @@ -676,6 +676,15 @@ bool ProfileManager::SaveProfile(std::string profile_name) } } + /*-------------------------------------------------*\ + | Preserve plugin data when no plugin manager is | + | available to refresh it. | + \*-------------------------------------------------*/ + if(existing_profile_json.contains("plugins")) + { + profile_json["plugins"] = existing_profile_json["plugins"]; + } + /*-------------------------------------------------*\ | Get plugin profile data if the plugin manager is | | available. If updating existing profile, only | @@ -696,7 +705,7 @@ bool ProfileManager::SaveProfile(std::string profile_name) for(unsigned int plugin_idx = 0; plugin_idx < plugin_manager->GetPluginCount(); plugin_idx++) { - if(profile_json["plugins"].contains(plugin_manager->GetPluginName(plugin_idx))) + if(existing_profile_json["plugins"].contains(plugin_manager->GetPluginName(plugin_idx))) { plugins_to_save.push_back(plugin_manager->GetPluginName(plugin_idx)); } ``` I built this candidate with Qt 6.11.2 and MSVC 2022. Repeating the same isolated command retained both plugin entries exactly and kept all 11 controllers. No change to OpenRGB's normal profile-editor workflow is required.